Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(roles-sync): fix CallableCache's NPE exception for caching synchronization strategy (backport #1077) #1079

Merged
merged 1 commit into from
Jul 21, 2023
Merged

fix(roles-sync): fix CallableCache's NPE exception for caching synchronization strategy (backport #1077) #1079

merged 1 commit into from
Jul 21, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 21, 2023

This is an automatic backport of pull request #1077 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@kirangodishala @mergify
fix(roles-sync): fix CallableCache's NPE exception for caching synchr…
9393ab5 
…onization strategy (#1077)

* fix(roles-sync): fix callable cache NPE exception for caching synchronization strategy

* fix(roles-sync): added tests

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 6d29188)
@mergify mergify bot requested review from cfieber and jonsie as code owners July 21, 2023 15:34
@mergify mergify bot mentioned this pull request Jul 21, 2023
Merged
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Jul 21, 2023
@mergify mergify bot added the auto merged label Jul 21, 2023
@mergify mergify bot merged commit 4aac1ef into release-1.29.x Jul 21, 2023
4 checks passed
@mergify mergify bot deleted the mergify/bp/release-1.29.x/pr-1077 branch July 21, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf approved these changes

@cfieber cfieber Awaiting requested review from cfieber cfieber is a code owner

@jonsie jonsie Awaiting requested review from jonsie jonsie is a code owner

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.29
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbyron-sf @spinnakerbot @kirangodishala