-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dependencies): dependency cleanup #377
Conversation
fiat-api/src/main/java/com/netflix/spinnaker/fiat/shared/FiatAuthenticationConfig.java
Outdated
Show resolved
Hide resolved
@@ -103,46 +103,18 @@ class FiatPermissionEvaluatorSpec extends Specification { | |||
.setAuthorizations([Authorization.READ] as Set)] as Set) | |||
upv.setServiceAccounts([new ServiceAccount.View().setName(svcAcct) | |||
.setMemberOf(["foo"])] as Set) | |||
fiatService.getUserPermission("testUser") >> upv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes in here are related to the change to Caffeine cache not being deterministic about the number of items (we have it set to maxItems = 0 for tests, but eviction back down to 0 happens async). The places where it was asserting the number of calls against the mock were brittle but also were not relevant to the tests - they were effectively stub calls anyway so the tests got a bit simpler as a result
0c221d1
to
05bcbf4
Compare
* removes lots of cargo-culted dependency declarations * trims dependencies in fiat-core and fiat-api to minimize the impact consuming projects * guava caches -> caffeine
* refactor(boot2): Mostly working... one transient test failure * chore(boot2): Bump to spin-deps rc.17, add spring properties migrator * chore(boot2): spin-dep rc.18 * fix(boot2): spin-dep rc.21; fixed failing test * fix(boot2): Fix transient test? * chore(boot2): Why cant I get this transient failure to happen on my laptop * fix(boot2): Im sure this will not solve it * chore(boot2): Cleanup of some speculative test output * chore(boot2): Disable parallel gradle execution * refactor(boot2): Mostly working... one transient test failure * chore(boot2): Bump to spin-deps rc.17, add spring properties migrator * chore(boot2): spin-dep rc.18 * fix(boot2): spin-dep rc.21; fixed failing test * chore(boot2): Why cant I get this transient failure to happen on my laptop * chore(boot2): Cleanup of some speculative test output * Add back JSON module. Fiat now boots up. * Fix tests * Fix case * chore(deps): latest spinnaker-dependencies * supply property placeholder for igor * update to kork bom (#376) * gradle 5.x * somebody set up us the BOM * fix(dependencies): dependency cleanup (#377) * fix(dependencies): dependency cleanup * removes lots of cargo-culted dependency declarations * trims dependencies in fiat-core and fiat-api to minimize the impact consuming projects * guava caches -> caffeine * fix(api): cleanup FiatAuthenticationConfig WebSecurityConfigurerAdapter * chore(dependencies): kork 4.1.0-rc.5-springBoot2 * chore(build): spinnaker-gradle-project 6.0.0 * chore(dependencies): kork 4.1.0-rc.11+springBoot2 * chore(build): remove useLastTag from non release travis buildscripts * chore(dependencies): kork 4.1.0-rc.13+springBoot2 * chore(dependencies): update to kork 5.0.0 * chore(build): remove unnecessary gradle config for jvm version
* refactor(boot2): Mostly working... one transient test failure * chore(boot2): Bump to spin-deps rc.17, add spring properties migrator * chore(boot2): spin-dep rc.18 * fix(boot2): spin-dep rc.21; fixed failing test * fix(boot2): Fix transient test? * chore(boot2): Why cant I get this transient failure to happen on my laptop * fix(boot2): Im sure this will not solve it * chore(boot2): Cleanup of some speculative test output * chore(boot2): Disable parallel gradle execution * refactor(boot2): Mostly working... one transient test failure * chore(boot2): Bump to spin-deps rc.17, add spring properties migrator * chore(boot2): spin-dep rc.18 * fix(boot2): spin-dep rc.21; fixed failing test * chore(boot2): Why cant I get this transient failure to happen on my laptop * chore(boot2): Cleanup of some speculative test output * Add back JSON module. Fiat now boots up. * Fix tests * Fix case * chore(deps): latest spinnaker-dependencies * supply property placeholder for igor * update to kork bom (spinnaker#376) * gradle 5.x * somebody set up us the BOM * fix(dependencies): dependency cleanup (spinnaker#377) * fix(dependencies): dependency cleanup * removes lots of cargo-culted dependency declarations * trims dependencies in fiat-core and fiat-api to minimize the impact consuming projects * guava caches -> caffeine * fix(api): cleanup FiatAuthenticationConfig WebSecurityConfigurerAdapter * chore(dependencies): kork 4.1.0-rc.5-springBoot2 * chore(build): spinnaker-gradle-project 6.0.0 * chore(dependencies): kork 4.1.0-rc.11+springBoot2 * chore(build): remove useLastTag from non release travis buildscripts * chore(dependencies): kork 4.1.0-rc.13+springBoot2 * chore(dependencies): update to kork 5.0.0 * chore(build): remove unnecessary gradle config for jvm version
* refactor(boot2): Mostly working... one transient test failure * chore(boot2): Bump to spin-deps rc.17, add spring properties migrator * chore(boot2): spin-dep rc.18 * fix(boot2): spin-dep rc.21; fixed failing test * fix(boot2): Fix transient test? * chore(boot2): Why cant I get this transient failure to happen on my laptop * fix(boot2): Im sure this will not solve it * chore(boot2): Cleanup of some speculative test output * chore(boot2): Disable parallel gradle execution * refactor(boot2): Mostly working... one transient test failure * chore(boot2): Bump to spin-deps rc.17, add spring properties migrator * chore(boot2): spin-dep rc.18 * fix(boot2): spin-dep rc.21; fixed failing test * chore(boot2): Why cant I get this transient failure to happen on my laptop * chore(boot2): Cleanup of some speculative test output * Add back JSON module. Fiat now boots up. * Fix tests * Fix case * chore(deps): latest spinnaker-dependencies * supply property placeholder for igor * update to kork bom (spinnaker#376) * gradle 5.x * somebody set up us the BOM * fix(dependencies): dependency cleanup (spinnaker#377) * fix(dependencies): dependency cleanup * removes lots of cargo-culted dependency declarations * trims dependencies in fiat-core and fiat-api to minimize the impact consuming projects * guava caches -> caffeine * fix(api): cleanup FiatAuthenticationConfig WebSecurityConfigurerAdapter * chore(dependencies): kork 4.1.0-rc.5-springBoot2 * chore(build): spinnaker-gradle-project 6.0.0 * chore(dependencies): kork 4.1.0-rc.11+springBoot2 * chore(build): remove useLastTag from non release travis buildscripts * chore(dependencies): kork 4.1.0-rc.13+springBoot2 * chore(dependencies): update to kork 5.0.0 * chore(build): remove unnecessary gradle config for jvm version
impact consuming projects