fix(dependencies): dependency cleanup #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfieber
commented
Apr 17, 2019
fiat-api/src/main/java/com/netflix/spinnaker/fiat/shared/FiatAuthenticationConfig.java
Outdated
Show resolved
Hide resolved
cfieber
commented
Apr 17, 2019
| @@ -103,46 +103,18 @@ class FiatPermissionEvaluatorSpec extends Specification { | |||
| .setAuthorizations([Authorization.READ] as Set)] as Set) | |||
| upv.setServiceAccounts([new ServiceAccount.View().setName(svcAcct) | |||
| .setMemberOf(["foo"])] as Set) | |||
| fiatService.getUserPermission("testUser") >> upv | |||
There was a problem hiding this comment.
changes in here are related to the change to Caffeine cache not being deterministic about the number of items (we have it set to maxItems = 0 for tests, but eviction back down to 0 happens async). The places where it was asserting the number of calls against the mock were brittle but also were not relevant to the tests - they were effectively stub calls anyway so the tests got a bit simpler as a result
cfieber
force-pushed
the
dep_cleanup
branch
2 times, most recently
from
0c221d1
to
05bcbf4
Compare
* removes lots of cargo-culted dependency declarations * trims dependencies in fiat-core and fiat-api to minimize the impact consuming projects * guava caches -> caffeine
cfieber
added a commit
that referenced
this pull request
Apr 24, 2019
* refactor(boot2): Mostly working... one transient test failure * chore(boot2): Bump to spin-deps rc.17, add spring properties migrator * chore(boot2): spin-dep rc.18 * fix(boot2): spin-dep rc.21; fixed failing test * fix(boot2): Fix transient test? * chore(boot2): Why cant I get this transient failure to happen on my laptop * fix(boot2): Im sure this will not solve it * chore(boot2): Cleanup of some speculative test output * chore(boot2): Disable parallel gradle execution * refactor(boot2): Mostly working... one transient test failure * chore(boot2): Bump to spin-deps rc.17, add spring properties migrator * chore(boot2): spin-dep rc.18 * fix(boot2): spin-dep rc.21; fixed failing test * chore(boot2): Why cant I get this transient failure to happen on my laptop * chore(boot2): Cleanup of some speculative test output * Add back JSON module. Fiat now boots up. * Fix tests * Fix case * chore(deps): latest spinnaker-dependencies * supply property placeholder for igor * update to kork bom (#376) * gradle 5.x * somebody set up us the BOM * fix(dependencies): dependency cleanup (#377) * fix(dependencies): dependency cleanup * removes lots of cargo-culted dependency declarations * trims dependencies in fiat-core and fiat-api to minimize the impact consuming projects * guava caches -> caffeine * fix(api): cleanup FiatAuthenticationConfig WebSecurityConfigurerAdapter * chore(dependencies): kork 4.1.0-rc.5-springBoot2 * chore(build): spinnaker-gradle-project 6.0.0 * chore(dependencies): kork 4.1.0-rc.11+springBoot2 * chore(build): remove useLastTag from non release travis buildscripts * chore(dependencies): kork 4.1.0-rc.13+springBoot2 * chore(dependencies): update to kork 5.0.0 * chore(build): remove unnecessary gradle config for jvm version
dibyom
pushed a commit
to dibyom/fiat
that referenced
this pull request
Apr 26, 2019
* refactor(boot2): Mostly working... one transient test failure * chore(boot2): Bump to spin-deps rc.17, add spring properties migrator * chore(boot2): spin-dep rc.18 * fix(boot2): spin-dep rc.21; fixed failing test * fix(boot2): Fix transient test? * chore(boot2): Why cant I get this transient failure to happen on my laptop * fix(boot2): Im sure this will not solve it * chore(boot2): Cleanup of some speculative test output * chore(boot2): Disable parallel gradle execution * refactor(boot2): Mostly working... one transient test failure * chore(boot2): Bump to spin-deps rc.17, add spring properties migrator * chore(boot2): spin-dep rc.18 * fix(boot2): spin-dep rc.21; fixed failing test * chore(boot2): Why cant I get this transient failure to happen on my laptop * chore(boot2): Cleanup of some speculative test output * Add back JSON module. Fiat now boots up. * Fix tests * Fix case * chore(deps): latest spinnaker-dependencies * supply property placeholder for igor * update to kork bom (spinnaker#376) * gradle 5.x * somebody set up us the BOM * fix(dependencies): dependency cleanup (spinnaker#377) * fix(dependencies): dependency cleanup * removes lots of cargo-culted dependency declarations * trims dependencies in fiat-core and fiat-api to minimize the impact consuming projects * guava caches -> caffeine * fix(api): cleanup FiatAuthenticationConfig WebSecurityConfigurerAdapter * chore(dependencies): kork 4.1.0-rc.5-springBoot2 * chore(build): spinnaker-gradle-project 6.0.0 * chore(dependencies): kork 4.1.0-rc.11+springBoot2 * chore(build): remove useLastTag from non release travis buildscripts * chore(dependencies): kork 4.1.0-rc.13+springBoot2 * chore(dependencies): update to kork 5.0.0 * chore(build): remove unnecessary gradle config for jvm version
clanesf
pushed a commit
to clanesf/fiat
that referenced
this pull request
Jul 12, 2019
* refactor(boot2): Mostly working... one transient test failure * chore(boot2): Bump to spin-deps rc.17, add spring properties migrator * chore(boot2): spin-dep rc.18 * fix(boot2): spin-dep rc.21; fixed failing test * fix(boot2): Fix transient test? * chore(boot2): Why cant I get this transient failure to happen on my laptop * fix(boot2): Im sure this will not solve it * chore(boot2): Cleanup of some speculative test output * chore(boot2): Disable parallel gradle execution * refactor(boot2): Mostly working... one transient test failure * chore(boot2): Bump to spin-deps rc.17, add spring properties migrator * chore(boot2): spin-dep rc.18 * fix(boot2): spin-dep rc.21; fixed failing test * chore(boot2): Why cant I get this transient failure to happen on my laptop * chore(boot2): Cleanup of some speculative test output * Add back JSON module. Fiat now boots up. * Fix tests * Fix case * chore(deps): latest spinnaker-dependencies * supply property placeholder for igor * update to kork bom (spinnaker#376) * gradle 5.x * somebody set up us the BOM * fix(dependencies): dependency cleanup (spinnaker#377) * fix(dependencies): dependency cleanup * removes lots of cargo-culted dependency declarations * trims dependencies in fiat-core and fiat-api to minimize the impact consuming projects * guava caches -> caffeine * fix(api): cleanup FiatAuthenticationConfig WebSecurityConfigurerAdapter * chore(dependencies): kork 4.1.0-rc.5-springBoot2 * chore(build): spinnaker-gradle-project 6.0.0 * chore(dependencies): kork 4.1.0-rc.11+springBoot2 * chore(build): remove useLastTag from non release travis buildscripts * chore(dependencies): kork 4.1.0-rc.13+springBoot2 * chore(dependencies): update to kork 5.0.0 * chore(build): remove unnecessary gradle config for jvm version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impact consuming projects