Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Support legacyFallback for BUILD_SERVICE #385

Merged
merged 1 commit into from
Apr 22, 2019

Conversation

ajordens
Copy link
Contributor

When service.fiat.legacyFallback is true, this will implicitly allow
access to all build services in the event that fiat is unavailable.

When `service.fiat.legacyFallback` is `true`, this will implicitly allow
access to all build services in the event that `fiat` is unavailable.
@ajordens
Copy link
Contributor Author

@dibyom We are currently going through an exercise to understand the situation if (and when) fiat were to become unavailable.

Since our adoption, we've always been supporting a legacyFallback model wherein we effectively fall back to the state that existed prior to fiat (account restrictions only).

This may need revisiting at some point but it's a bare minimum that we'd like to see supported for now.

@ajordens
Copy link
Contributor Author

Also thinking that there may be a model where source of truth systems (ie. jenkins, clouddriver) could supply their own fallbacks (or an extension point allowing a user to supply their own fallback logic).

Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The legacyFallback makes sense for clouddriver accounts. Will this allow access to all build services to all users if Fiat is not available?

@ajordens
Copy link
Contributor Author

@dibyom If enabled, it would.

We've bounced around the idea for an optional extension point (likely in igor) that could potentially blacklist certain build services even for fallbacks.

@ajordens ajordens merged commit 4651b4b into spinnaker:master Apr 22, 2019
dibyom pushed a commit to dibyom/fiat that referenced this pull request Apr 26, 2019
When `service.fiat.legacyFallback` is `true`, this will implicitly allow
access to all build services in the event that `fiat` is unavailable.
clanesf pushed a commit to clanesf/fiat that referenced this pull request Jul 12, 2019
When `service.fiat.legacyFallback` is `true`, this will implicitly allow
access to all build services in the event that `fiat` is unavailable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants