feat(authn/saml): Configurable signature digest algorithm #1269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Spinnaker is configured with SAML authentication, the
SAMLRequest
is always signed with theSHA1
digest algorithm (SignatureMethod
andDigestMethod
of the request):For security reasons,
SHA1
may not work with IdP's that mandate a stronger digest algorithm. We also cannot just bump to SHA256 or higher because there's the risk of breaking older IdP's that don't support stronger algorithms.This PR introduces a new SAML optional configuration setting
signatureDigest
, used for signing bothSignature
andDigest
parts of the SAML request. Valid values areSHA1, SHA256, SHA384, SHA512, RIPEMD160, MD5
which come from the constants defined in opensamlSignatureConstants
, which is the underlying implementation being used. If the setting is not defined, it defaults toSHA1
for keeping compatibility with existing installations.