-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support insight actions within Instance and ServerGroup services #47
Conversation
- Common insight actions can be specified in configuration Relates to spinnaker/deck#108
@CompileStatic | ||
@Component | ||
@ConfigurationProperties("insights") | ||
class InsightConfiguration { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/spinnaker-netflix/gate-nflx/commit/2ef7c4fb5091b3722cb3d2b37dc18fb29ba9535b of what is configurable.
@danveloper Feel free to chime in. Opt'd to support configurable across-the-board insight links within Gate (didn't see a strong argument to push this into another service right now). If/when we get requests to add application-specific links (specific dashboards, etc.) than we could look at flapjack (a tag) or front50 (incorporated into metadata). Looks like https://github.com/spinnaker/deck/issues/108#issuecomment-68962984 in deck. |
It seems weird to get it from here instead of just configuring this in Deck. These don't seem like values that would change that frequently, so I'm not sure they need to be data driven. |
Fair comment. I erred towards exposing it via Gate to leave open the On Tuesday, January 6, 2015, Dan Woods notifications@github.com wrote:
|
Support insight actions within Instance and ServerGroup services
Visibility service configurations added
Co-authored-by: root <root@1b5cd831368a>
Updated splunkLog filename & extension
Relates to spinnaker/deck#108