Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support insight actions within Instance and ServerGroup services #47

Merged
merged 1 commit into from
Jan 7, 2015

Conversation

ajordens
Copy link
Contributor

@ajordens ajordens commented Jan 7, 2015

  • Common insight actions can be specified in configuration

Relates to spinnaker/deck#108

- Common insight actions can be specified in configuration

Relates to spinnaker/deck#108
@CompileStatic
@Component
@ConfigurationProperties("insights")
class InsightConfiguration {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajordens
Copy link
Contributor Author

ajordens commented Jan 7, 2015

@danveloper Feel free to chime in. Opt'd to support configurable across-the-board insight links within Gate (didn't see a strong argument to push this into another service right now).

If/when we get requests to add application-specific links (specific dashboards, etc.) than we could look at flapjack (a tag) or front50 (incorporated into metadata).

Looks like https://github.com/spinnaker/deck/issues/108#issuecomment-68962984 in deck.

@danveloper
Copy link
Contributor

It seems weird to get it from here instead of just configuring this in Deck. These don't seem like values that would change that frequently, so I'm not sure they need to be data driven.

@ajordens
Copy link
Contributor Author

ajordens commented Jan 7, 2015

Fair comment. I erred towards exposing it via Gate to leave open the
possibility of surfacing user supplied/per app links if needed.

On Tuesday, January 6, 2015, Dan Woods notifications@github.com wrote:

It seems weird to get it from here instead of just configuring this in
Deck. These don't seem like values that would change over that frequently,
so I'm not sure they need to be data driven.


Reply to this email directly or view it on GitHub
#47 (comment).

ajordens added a commit that referenced this pull request Jan 7, 2015
Support insight actions within Instance and ServerGroup services
@ajordens ajordens merged commit 62cc87b into master Jan 7, 2015
@ajordens ajordens deleted the add-common-insight-actions branch January 7, 2015 19:56
abhinaybyrisetty referenced this pull request in OpsMx/gate Mar 11, 2021
Visibility service configurations added
apoorvmahajan pushed a commit to apoorvmahajan/gate that referenced this pull request Aug 29, 2022
sanopsmx added a commit to sanopsmx/gate that referenced this pull request Mar 11, 2024
Updated splunkLog filename & extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants