feat(gae): Adds endpoint to surfact GAE storage accounts. #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtk54
force-pushed
the
storage-accounts
branch
from
eedde7e to
ce05102
Compare
lwander
reviewed
Oct 17, 2017
| @@ -281,4 +281,7 @@ interface ClouddriverService { | |||
| Response getAdhocData(@Path(value = 'groupId', encode = false) String groupId, | |||
| @Path(value = 'bucketId', encode = false) String bucketId, | |||
| @Path(value = 'objectId', encode = false) String objectId) | |||
|
|
|||
| @GET('/appengine/storage/list') | |||
| List<String> getAppengineStorageAccounts() | |||
There was a problem hiding this comment.
I wouldn't couple this with appengine. In the end this should just read /storage/account/ or something similar
There was a problem hiding this comment.
Oh I see this is just for clouddriver - we'll have to fix that there later
There was a problem hiding this comment.
Yeah, let's do that now (I can do that if you want). Let's just make it a GET to /storage.
lwander
reviewed
Oct 17, 2017
| import java.util.List; | ||
|
|
||
| @RestController | ||
| @RequestMapping("/appengine/storage/list") |
There was a problem hiding this comment.
This is where we should probably not include appengine in the name of the path, to save time refactoring later.
jtk54
force-pushed
the
storage-accounts
branch
from
ce05102 to
140e2a9
Compare
jtk54
force-pushed
the
storage-accounts
branch
from
140e2a9 to
412ae00
Compare
|
Renamed endpoints. |
BrunoCarrier
added a commit
to lookout/gate
that referenced
this pull request
Oct 26, 2017
* feat(gae): Adds endpoint to surfact GAE storage accounts. (spinnaker#470) * feat(echo/pubsub): Expose endpoint to query subscriptions. (spinnaker#472)
dkirillov
added a commit
to lookout/gate
that referenced
this pull request
Dec 6, 2017
* feat(gae): Adds endpoint to surfact GAE storage accounts. (spinnaker#470) * feat(echo/pubsub): Expose endpoint to query subscriptions. (spinnaker#472) * fix(pipeline_template): Default no scopes for pipeline templates (spinnaker#473) * feat(v2-canary): add application query param to config list endpoint (spinnaker#474) * fix(web): NPE when no scopes provided (spinnaker#475) * chore(canary-v2): Do not return bare strings. (spinnaker#477) * feat(pipeline_template): Support pipeline templates with dynamic sources (spinnaker#471) Pass along pipelineConfigId and executionId parameters for `/pipelineTemplates/resolve` * chore(swagger): Add webhooks endpoint to swagger docs (spinnaker#410) * fix(authN): Handle case of missing port(s) in post authN redirect. (spinnaker#467) - if port 443 is missing, but the scheme is https, we should set the default to 443, instead of -1. * feat(core): server group manager controller (spinnaker#478) * feat(pipelines): validate required parameters are supplied on pipeline trigger (spinnaker#479) * feat(core/serverGroups): Get a list of servergroups by name (spinnaker#480) Depends on spinnaker/clouddriver#2114 * feat(manifest): get manifest controller (spinnaker#481) * feat(xenial_builds): Add systemd configuration for Gate. (spinnaker#483) * feat(xenial_builds): Add systemd configuration for Gate. * chore(systemd_logs): Remove unneeded log redirection. (spinnaker#485) * feat(v2-canary): canary result endpoint, metric set list pair endpoint, refactoring (spinnaker#482) * feat(x509) Allow x509 and LDAP to be used together (spinnaker#476)
danielpeach
pushed a commit
to danielpeach/gate
that referenced
this pull request
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.