adds a flag to the onelogin config to requireAuthentication #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if present, all requests aside from the /auth endpoint require and authenticated session. effectively disables access from the api client for scripting, but supports a browser only mode we can add a different supported auth mechanism for scripting clients to authenticate in the future and make this a non optional flag
|
I've tested the behaviour of this with deck and it seems to behave well:
|
| @@ -60,15 +59,27 @@ class OneLoginSecurityConfig extends WebSecurityConfigurerAdapter { | |||
| @ConfigurationProperties("onelogin") | |||
| static class OneLoginSecurityConfigProperties { | |||
| Boolean enabled | |||
| Boolean requireAuthentication | |||
There was a problem hiding this comment.
if not present will be false to match previous behaviour
cfieber
added a commit
that referenced
this pull request
Feb 2, 2015
adds a flag to the onelogin config to requireAuthentication
abhinaybyrisetty
referenced
this pull request
in OpsMx/gate
Mar 11, 2021
Op 3853 customize gate login form
This was referenced Mar 11, 2021
Closed
Closed
apoorvmahajan
pushed a commit
to apoorvmahajan/gate
that referenced
this pull request
Aug 29, 2022
…be the source of truth for applications (spinnaker#60)
kirangodishala
pushed a commit
to kirangodishala/gate
that referenced
this pull request
May 23, 2023
Auth turned off for static and runtime policy trigger APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if present, all requests aside from the /auth endpoint require and authenticated session.
effectively disables access from the api client for scripting, but supports a browser only mode
we can add a different supported auth mechanism for scripting clients to authenticate in the future and
make this a non optional flag