Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: New Approver status for @kevinawoo #19

Closed
6 tasks done
kevinawoo opened this issue Aug 15, 2019 · 9 comments · Fixed by spinnaker/spinnaker#4791
Closed
6 tasks done

REQUEST: New Approver status for @kevinawoo #19

kevinawoo opened this issue Aug 15, 2019 · 9 comments · Fixed by spinnaker/spinnaker#4791
Labels
approved committee/technical-oversight Denotes an issue or PR intended to be handled by the technical oversight committee.

Comments

@kevinawoo
Copy link
Member

kevinawoo commented Aug 15, 2019

Github Username

@kevinawoo

Requirements

  • Belongs to an organization with significant stake in project
  • Known active participant in the community
  • Has submitted at least 5 PRs of significant scope that are merged
  • Is already fulfilling the Reviewer role
  • Has reviewed 5 PRs of significant scope
  • Sponsored by 2 Approvers

Sponsors

List of qualifications for this position

@christopherthielen
Copy link
Contributor

👍 from me

@ethanfrogers
Copy link
Contributor

Same! +1!

@duftler
Copy link

duftler commented Aug 15, 2019

I am in favor of Kevin becoming an Approver.

+1

@maggieneterval
Copy link
Contributor

+1 😃

@robzienert robzienert added the committee/technical-oversight Denotes an issue or PR intended to be handled by the technical oversight committee. label Aug 16, 2019
@robzienert
Copy link
Member

TOC +1

1 similar comment
@ezimanyi
Copy link
Contributor

TOC +1

@ajordens
Copy link
Contributor

TOC +1

@aglover
Copy link
Contributor

aglover commented Aug 23, 2019

Sounds like there's a quorum from the TOC to make this official? @ajordens @robzienert @ezimanyi

@ezimanyi
Copy link
Contributor

This has been approved by the TOC. I just sent an invite for @kevinawoo to join the approvers Github team; the above PR will update the documentation to reflect that (and this issue will auto-close when the documentation PR is merged).

ezimanyi added a commit to spinnaker/spinnaker that referenced this issue Aug 26, 2019
* fix(approvers): Fix line endings in reviewers.md

This file has CRLF line endings, which doesn't match the rest of
the repo.

* fix(approvers): Alphabetize reviewers/approvers

* feat(approvers): Add kevinawoo to approvers

Approved by TOC in spinnaker/governance#19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved committee/technical-oversight Denotes an issue or PR intended to be handled by the technical oversight committee.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants