Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): Bump spinnaker-dependencies #1062

Merged
merged 1 commit into from
Oct 17, 2018
Merged

chore(dependencies): Bump spinnaker-dependencies #1062

merged 1 commit into from
Oct 17, 2018

Conversation

ezimanyi
Copy link
Contributor

@ezimanyi ezimanyi commented Oct 5, 2018

No description provided.

@ezimanyi
Copy link
Contributor Author

ezimanyi commented Oct 5, 2018

Needed to update the GCS validator to handle a change in the constructor due to:

I just used the default retry parameters, as given this is Halyard which generates the config files, we don't have a config file to read (as we do in front50).

@ezimanyi ezimanyi requested a review from lwander October 5, 2018 19:10
@ezimanyi
Copy link
Contributor Author

ezimanyi commented Oct 5, 2018

This fixes the test that broke in the auto-update done in #1060

@ezimanyi
Copy link
Contributor Author

Mind taking a look @lwander?

Copy link
Member

@lwander lwander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think builds are failing due to the lack of GH releases... will fix now

@ezimanyi ezimanyi merged commit ef1fadd into spinnaker:master Oct 17, 2018
@ezimanyi ezimanyi deleted the bump-dependencies branch October 17, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants