Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add upperBound/tooHighMessage for mineCanary feature flag #1768

Merged
merged 1 commit into from
Aug 6, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,11 @@ public NodeIterator getChildren() {

@ValidForSpinnakerVersion(
lowerBound = "1.5.0",
upperBound = "1.22.0",
tooLowMessage =
"Canary is not configurable prior to this release. Will be stable at a later release.")
"Canary is not configurable prior to this release. Will be stable at a later release.",
tooHighMessage =
"This flag gates legacy canary stages and does not need to be enabled for OSS canary analysis support.")
private Boolean mineCanary;

@ValidForSpinnakerVersion(
Expand Down