Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Echoservice): make changes to Echoservice use customSpinnake… #1124

Merged

Conversation

Luthan95
Copy link
Contributor

@Luthan95 Luthan95 commented May 8, 2023

…r Exceptions using SpinnakerRetrofitErrorHandler

make use of SpinnakerRetrofitErrorHandler to utilize custom spinnaker exception and replace RetrofitError

…r Exceptions using SpinnakerRetrofitErrorHandler
@SheetalAtre SheetalAtre force-pushed the custom_exception_handling_retrofit_echo branch from c2eac17 to 7036c30 Compare August 29, 2023 13:19
@dbyron-sf
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2023

update

✅ Branch has been successfully updated

@dbyron-sf dbyron-sf marked this pull request as ready for review September 10, 2023 20:59
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Sep 10, 2023
@mergify mergify bot added the auto merged label Sep 10, 2023
@mergify mergify bot merged commit ae0d3d5 into spinnaker:master Sep 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants