Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(front50client): make changes to Front50Service and Clouddriv… #1125

Conversation

Luthan95
Copy link
Contributor

…er to use Spinnaker custom exception instead of RetrofitError using SpinnakerRetrofitErrorHandler

Make use of Spinnaker custom exceptions and remove RetrofitError direct usage in code by making use SpinnakerRetrofitErrorHandler

@SheetalAtre SheetalAtre force-pushed the custom_exception_handling_front50_clouddriver branch 2 times, most recently from 0493a17 to 2be8f9c Compare August 29, 2023 13:31
…trofitErrorHandler in DockerRegistry and PluginMonitor for custom error handling in front50 and clouddriver
@SheetalAtre SheetalAtre force-pushed the custom_exception_handling_front50_clouddriver branch from 2be8f9c to 4ea59ed Compare August 29, 2023 14:46
@dbyron-sf
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2023

update

✅ Branch has been successfully updated

@dbyron-sf dbyron-sf marked this pull request as ready for review September 14, 2023 22:51
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Sep 14, 2023
@mergify mergify bot added the auto merged label Sep 14, 2023
@mergify mergify bot merged commit fa7bfa8 into spinnaker:master Sep 14, 2023
4 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants