Skip to content

Commit

Permalink
fix(requests): Correctly compare header names (#283)
Browse files Browse the repository at this point in the history
Fixes a bug resulting from #270
where X-SPINNAKER-* headers stopped being propagated because they were
not compared in a case insensitive way
  • Loading branch information
marchello2000 authored May 6, 2019
1 parent 5180c5b commit 5f20b43
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,10 @@ class AuthenticatedRequestFilter implements Filter {
Enumeration<String> headers = httpServletRequest.getHeaderNames()

for (header in headers) {
if (header.startsWith(Header.XSpinnakerPrefix)) {
otherSpinnakerHeaders.put(header, httpServletRequest.getHeader(header))
String headerUpper = header.toUpperCase()

if (headerUpper.startsWith(Header.XSpinnakerPrefix)) {
otherSpinnakerHeaders.put(headerUpper, httpServletRequest.getHeader(header))
}
}
}
Expand Down

0 comments on commit 5f20b43

Please sign in to comment.