Skip to content

Commit

Permalink
fix(clouddriver): Revert change to pin source capacity for redblack d…
Browse files Browse the repository at this point in the history
…eploys (#2756)
  • Loading branch information
ajordens authored Mar 14, 2019
1 parent 10e8681 commit 309d4aa
Showing 1 changed file with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,8 @@ class AwsDeployStagePreProcessor implements DeployStagePreProcessor {
}

private static boolean shouldPinSourceServerGroup(String strategy) {
// TODO(dreynaud): consider adding support for highlander
// it would make sense to avoid the source server group getting scaled down in case of a long running
// deploy that needs to be canceled, but if we just add "highlander" in the supported strategies here
// the unpin task fails as it is started after the shrinkCluster task
return strategy in ["rollingredblack", "redblack"]
// TODO-AJ consciously only enabling for rolling red/black -- will add support for other strategies after it's working
return strategy == "rollingredblack"
}

private static boolean shouldCheckServerGroupsPreconditions(StageData stageData) {
Expand Down

0 comments on commit 309d4aa

Please sign in to comment.