Skip to content

Commit

Permalink
Make WaitForClusterDisableTask configurable in yml (#1824)
Browse files Browse the repository at this point in the history
  • Loading branch information
yue9944882 authored and anotherchrisberry committed Nov 30, 2017
1 parent 8eed431 commit 8cdd337
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,13 @@ import com.netflix.spinnaker.orca.clouddriver.utils.HealthHelper
import com.netflix.spinnaker.orca.pipeline.model.Stage
import org.springframework.beans.factory.annotation.Autowired
import org.springframework.stereotype.Component
import org.springframework.beans.factory.annotation.Value

@Component
class WaitForClusterDisableTask extends AbstractWaitForClusterWideClouddriverTask implements CloudProviderAware {
private static final int MINIMUM_WAIT_TIME_MS = 90000

@Value('${tasks.disableClusterMinTimeMillis:90000')

This comment has been minimized.

Copy link
@imosquera

imosquera Nov 30, 2017

Contributor

This breaks orca because there is a missing end brace. It expects an integer but the missing brace makes it a string

This comment has been minimized.

Copy link
@andrewbackes

andrewbackes Nov 30, 2017

Member

Fix is here: #1826

private int MINIMUM_WAIT_TIME_MS

private final Map<String, String> healthProviderNamesByPlatform

Expand Down

0 comments on commit 8cdd337

Please sign in to comment.