Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(artifacts): Fix successful filter for find artifacts #2780

Merged
merged 3 commits into from
Mar 22, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,18 @@ public TaskResult execute(@Nonnull Stage stage) {

@Data
private static class ExecutionOptions {
// Accept either 'succeeded' or 'successful' in the stage config. The front-end sets 'successful', but due to a bug
// this class was only looking for 'succeeded'. Fix this by accepting 'successful' but to avoid breaking anyone who
// discovered this bug and manually edited their stage to set 'succeeded', continue to accept 'succeeded'.
boolean succeeded;
boolean successful;

boolean terminal;
boolean running;

ExecutionCriteria toCriteria() {
List<String> statuses = new ArrayList<>();
if (succeeded) {
if (succeeded || successful) {
statuses.add("SUCCEEDED");
}

Expand Down