Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gcb): Use generic maps for GCB objects #2853

Merged
merged 1 commit into from
Apr 19, 2019
Merged

refactor(gcb): Use generic maps for GCB objects #2853

merged 1 commit into from
Apr 19, 2019

Commits on Apr 19, 2019

  1. refactor(gcb): Use generic maps for GCB objects

    Orca currently deserializes the build configuration in the stage to
    a Build object only to send it immediately over to igor (which
    re-serializes it). As orca doesn't actually need to know any of the
    details about the Build object it's sending over, just use a generic
    Map.
    
    This addresses an issue where some fields are not correctly
    deserializing using the default objectMapper; I'll need to
    work around this in igor, but this reduces the scope of where
    that workaround needs to live.  (This also allows us to
    better encapsulate which microservices actually need to know
    about GCB objects.)
    ezimanyi committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    7497744 View commit details
    Browse the repository at this point in the history