fix(orca): if build stage fails and prop file exists, try and fetch

orca-igor/src/main/groovy/com/netflix/spinnaker/orca/igor/pipeline/CIStage.java

@@ -21,6 +21,7 @@
 import com.netflix.spinnaker.orca.igor.tasks.*;
 import com.netflix.spinnaker.orca.pipeline.StageDefinitionBuilder;
 import com.netflix.spinnaker.orca.pipeline.TaskNode;
+import com.netflix.spinnaker.orca.pipeline.graph.StageGraphBuilder;
 import com.netflix.spinnaker.orca.pipeline.model.Stage;
 import com.netflix.spinnaker.orca.pipeline.tasks.artifacts.BindProducedArtifactsTask;
 import lombok.RequiredArgsConstructor;
@@ -90,4 +91,27 @@ public Result cancel(final Stage stage) {
     }
     return new Result(stage, new HashMap());
   }
+
+  @Override
+  public void onFailureStages(@Nonnull Stage stage, @Nonnull StageGraphBuilder graph) {
+    CIStageDefinition stageDefinition = stage.mapTo(CIStageDefinition.class);
+    if (stageDefinition.getPropertyFile() != null && !stageDefinition.getPropertyFile().equals("")) {
+      log.info(
+        "Stage failed (stageId: {}, executionId: {}), trying to find requested property file in case it was archived.",
+        stage.getId(),
+        stage.getExecution().getId()
+      );
+      graph.add( (Stage s) -> {
+          s.setType(new GetPropertiesStage().getType());
+          s.setName("Try to get properties file");
+          Map<String, Object> context = new HashMap<>();
+          context.put("master", stageDefinition.getMaster());
+          context.put("job", stageDefinition.getJob());
+          context.put("propertyFile", stageDefinition.getPropertyFile());
+          context.put("buildNumber", stageDefinition.getBuildNumber());
+          s.setContext(context);
+        }
+      );
+    }
+  }
 }

orca-igor/src/main/groovy/com/netflix/spinnaker/orca/igor/pipeline/GetPropertiesStage.java

@@ -0,0 +1,34 @@
+/*
+ *
+ * Copyright 2019 Netflix, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License")
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package com.netflix.spinnaker.orca.igor.pipeline;
+
+import com.netflix.spinnaker.orca.igor.tasks.GetBuildPropertiesTask;
+import com.netflix.spinnaker.orca.pipeline.StageDefinitionBuilder;
+import com.netflix.spinnaker.orca.pipeline.TaskNode;
+import com.netflix.spinnaker.orca.pipeline.model.Stage;
+import org.springframework.stereotype.Component;
+
+import javax.annotation.Nonnull;
+
+@Component
+public class GetPropertiesStage implements StageDefinitionBuilder {
+  @Override
+  public void taskGraph(@Nonnull Stage stage, @Nonnull TaskNode.Builder builder) {
+    builder.withTask("getPropertiesFile", GetBuildPropertiesTask.class);
+  }
+}

orca-igor/src/main/groovy/com/netflix/spinnaker/orca/igor/tasks/GetBuildPropertiesTask.java

@@ -41,7 +41,12 @@ public class GetBuildPropertiesTask extends RetryableIgorTask {
       return TaskResult.SUCCEEDED;
     }
 
-    Map<String, Object> properties = buildService.getPropertyFile(stageDefinition.getBuildNumber(), stageDefinition.getPropertyFile(), stageDefinition.getMaster(), stageDefinition.getJob());
+    Map<String, Object> properties = buildService.getPropertyFile(
+      stageDefinition.getBuildNumber(),
+      stageDefinition.getPropertyFile(),
+      stageDefinition.getMaster(),
+      stageDefinition.getJob()
+    );
     if (properties.size() == 0) {
       throw new IllegalStateException(String.format("Expected properties file %s but it was either missing, empty or contained invalid syntax", stageDefinition.getPropertyFile()));
     }