Update Igor endpoints #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMeng
force-pushed
the
jenkins-folders
branch
2 times, most recently
from
863c5c4 to
eb429e3
Compare
AMeng
force-pushed
the
jenkins-folders
branch
4 times, most recently
from
f0c1c48 to
a24590b
Compare
|
@duftler - mind taking a look at the packageinfo changes to see if they make sense? |
|
The packageInfo changes LGTM. |
| @@ -26,7 +26,7 @@ import spock.lang.Unroll | |||
| class PackageInfoSpec extends Specification { | |||
|
|
|||
| @Subject | |||
| PackageInfo info = new PackageInfo(Mock(Stage), 'deb', '_', false, true, Mock(ObjectMapper)) | |||
| PackageInfo info = new PackageInfo(Mock(Stage), 'deb', '_', true, true, Mock(ObjectMapper)) | |||
There was a problem hiding this comment.
Is the change to that constructor parameter required for these tests to pass?
There was a problem hiding this comment.
No, but this forces the parseBuildInfoUrl method to be called (the one I've edited). Previously that method was not tested through here.
There was a problem hiding this comment.
Ok. Just wanted to be sure I hadn't missed something (since you've added an explicit test of that method here).
AMeng
force-pushed
the
jenkins-folders
branch
from
a24590b to
eaf0d7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: spinnaker/spinnaker#605
Depends on: spinnaker/igor#42