refact(gateapi): swagger 2.4.15 query params are typed now #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinawoo
changed the title
|
Not necessary a blocker, but swallowed decoding errors from the generated swagger Go code was discovered. Doing this work now will help us migrate to the later 2.x version much easier. |
This also removes "*malformed" test cases since 2.14.4 doesn't return parsing errors swagger-api/swagger-codegen#10434 reports the issue. hopefully swagger-api/swagger-codegen#10429 be merged will add that ability back in.
kevinawoo
force-pushed
the
feature/swagger-2.4.14
branch
from
2b2ba3f
to
dae2894
Compare
Chinikins
approved these changes
Aug 18, 2020
gsapkal
pushed a commit
to gsapkal/spin
that referenced
this pull request
Sep 10, 2020
…#292) * chore(gateapi): update gateapi from 5c625da5 using swagger 2.4.14 * feat(contribution): add instructions on how to generate gateapi using 2.4.1 * refact(gateapi): swagger 2.4.14 query params are typed now * tests(gateapi): gateapi generated code expects valid JSON and headers This also removes "*malformed" test cases since 2.14.4 doesn't return parsing errors swagger-api/swagger-codegen#10434 reports the issue. hopefully swagger-api/swagger-codegen#10429 be merged will add that ability back in. * refactor(imports): fixed import styling * chore(gateapi): use swagger-cli 2.4.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the swagger code gen to
2.4.15because of2.3.1required manual fixes after generating the go code withlocalvarfiles.Changes:
goimports