Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): Adds swabbie integration tests for docker builds #669

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jasonmcintosh
Copy link
Member

Duplicates most of the other project integration tests with a FEW changes

  • Uses valkey for redis (license concern) and uses version 7.

@dbyron-sf
Copy link
Contributor

Doesn't this need a chance to some github actions to actually run the tests?

Copy link
Contributor

@jervi jervi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jasonmcintosh
Copy link
Member Author

Doesn't this need a chance to some github actions to actually run the tests?

Yeah :) I'd not gotten all the pieces configured. I should have probably put this as "draft" but hadn't worried too much. I THINK it's actually in a pretty good state now for merge.

@@ -112,3 +112,8 @@ jobs:
tags: |
"${{ env.CONTAINER_REGISTRY }}/${{ steps.build_variables.outputs.REPO }}:${{ github.ref_name }}-latest-java11-unvalidated-ubuntu"
"${{ env.CONTAINER_REGISTRY }}/${{ steps.build_variables.outputs.REPO }}:${{ steps.build_variables.outputs.VERSION }}-java11-unvalidated-ubuntu"

- name: Test local slim container image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr.yml also needs this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks will add that :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And....it fails:

    APPLICATION FAILED TO START
    ***************************

    Description:

    Config data location '/home/spinnaker/.spinnaker/' does not exist

    Action:

    Check that the value '/home/spinnaker/.spinnaker/' is correct, or prefix it with 'optional:'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah :) That's that kork config with the default locations if I recall right. Will dig & fix here later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI fixed this with latest PR, but working through all the "clouddriver isn't available" as part of the integration tests. Got some more work to do on the downstream deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants