-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): Adds swabbie integration tests for docker builds #669
base: master
Are you sure you want to change the base?
Conversation
Doesn't this need a chance to some github actions to actually run the tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Yeah :) I'd not gotten all the pieces configured. I should have probably put this as "draft" but hadn't worried too much. I THINK it's actually in a pretty good state now for merge. |
@@ -112,3 +112,8 @@ jobs: | |||
tags: | | |||
"${{ env.CONTAINER_REGISTRY }}/${{ steps.build_variables.outputs.REPO }}:${{ github.ref_name }}-latest-java11-unvalidated-ubuntu" | |||
"${{ env.CONTAINER_REGISTRY }}/${{ steps.build_variables.outputs.REPO }}:${{ steps.build_variables.outputs.VERSION }}-java11-unvalidated-ubuntu" | |||
|
|||
- name: Test local slim container image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr.yml also needs this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks will add that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And....it fails:
APPLICATION FAILED TO START
***************************
Description:
Config data location '/home/spinnaker/.spinnaker/' does not exist
Action:
Check that the value '/home/spinnaker/.spinnaker/' is correct, or prefix it with 'optional:'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah :) That's that kork config with the default locations if I recall right. Will dig & fix here later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/spinnaker/kork/blob/2b857f57c85a8c821e35da68c1207fbf00cb335d/kork-config/src/main/java/com/netflix/spinnaker/kork/boot/DefaultPropertiesBuilder.java#L32C1-L33C1 this was what was thinking. Checking on the config here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI fixed this with latest PR, but working through all the "clouddriver isn't available" as part of the integration tests. Got some more work to do on the downstream deps.
Duplicates most of the other project integration tests with a FEW changes