Skip to content
This repository has been archived by the owner on Feb 3, 2022. It is now read-only.

fix(bug): fix issue with not working informer.Workers RPC call #65

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

rustatian
Copy link
Contributor

@rustatian rustatian commented Jun 2, 2021

Reason for This PR

closes: roadrunner-server/roadrunner#686

Description of Changes

  • Do not error in case of 0 workers returned by informer.Workers, just get the next plugin.
  • Remove deprecated linters (golint -> revive)
  • Add new plugins

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added the B-performance Bug: performance issues label Jun 2, 2021
@rustatian rustatian added this to the 2.3.0 milestone Jun 2, 2021
@rustatian rustatian requested a review from wolfy-j June 2, 2021 18:35
@rustatian rustatian self-assigned this Jun 2, 2021
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #65 (a44863c) into master (11e6fe7) will increase coverage by 0.14%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   50.83%   50.98%   +0.14%     
==========================================
  Files          11       11              
  Lines         301      306       +5     
==========================================
+ Hits          153      156       +3     
- Misses        137      139       +2     
  Partials       11       11              
Impacted Files Coverage Δ
internal/cli/workers/command.go 23.72% <0.00%> (-0.84%) ⬇️
internal/container/plugins.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e6fe7...a44863c. Read the comment docs.

- Update CHANGELOG
- Add new plugins

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian merged commit 41224bb into master Jun 2, 2021
@rustatian rustatian deleted the bug/workers.list_returns_wrong_plugins branch June 2, 2021 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B-performance Bug: performance issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] rr workers not working in Laravel Octane
1 participant