-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications are getting in the way #903
Comments
Thanks! Do you think it's possible to have it in the layout.html but after the header with the links and logo? |
The current screenshot was made with the Do you mean to have it on the right in the top navbar, after the project menu? Or at the bottom of this? |
I'm thinking about putting it after the top navbar and the project menu. At the bottom of it, yes. |
A design warning : if flash messages are to be put back in flow : be sure that its vanishing after a couple of seconds does not make the whole page content move up. Some UI act like that, and that is very annoying. (a solution to that is to remove notification from auto-hiding) |
Since #856 there is no auto-hide anymore. But that's the main problem I encountered: how to integrate flash message without moving existing content. Even when I click on some "Close" action, I don't want the whole content to move. On top of that, moving the content can bring some other design issues. |
After seeing the issue in many angle, here is my best proposal so far: Peek.11-11-2021.23-00.mp4I didn't modify the absolute positioning. The trick was to add an empty div of 4.5rem height (as before) on top of messages, but only for screen larger than |
Sorry I didn't came back to you sooner @Glandos. It seems good enough to me 👍 |
Fixes spiral-project#903 They are now a macro, and can be called within other templates. This give the ability to fit them anywhere, at the cost of template complexity.
See .
I'm not sure what to do about this: we could probably make the notifiications in the flow, and not floating on top of the rest of the content.
The text was updated successfully, but these errors were encountered: