feat: preprend "I Hate Money" to the page title #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for taking the time to propose this. I feel that "I Hate Money" in addition to "Account manager" might be too much. Maybe we should decide on one of them? Also, I'm thinking we might want to introduce a setting for this, so it's possible to change the name of the app, if people want to "rebrand" it somehow. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In browser tabs, I like to see the name of the website. I used the same format as it's done in the feed:
ihatemoney/ihatemoney/templates/project_feed.xml
Line 7 in 6582e2c
So here is a tiny change, and it's also OK to close the PR if such a modification is not welcome :)