Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streaming SapiEmitter #602

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Streaming SapiEmitter #602

merged 1 commit into from
Mar 24, 2022

Conversation

roxblnfk
Copy link
Member

Part of #598

@roxblnfk
SapiEmitter now emits streaming;
fc39bc1 
Add tests for SapiEmitter;
@roxblnfk roxblnfk requested a review from butschster March 23, 2022 09:29
@codecov
Copy link

codecov bot commented Mar 23, 2022 •
edited
Loading

Codecov Report

Merging #602 (fc39bc1) into master (673f680) will decrease coverage by 0.03%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##             master     #602      +/-   ##
============================================
- Coverage     79.81%   79.78%   -0.04%     
- Complexity     6603     6620      +17     
============================================
  Files           743      744       +1     
  Lines         16749    16787      +38     
============================================
+ Hits          13369    13393      +24     
- Misses         3380     3394      +14
Impacted Files Coverage Δ
src/Framework/Http/SapiDispatcher.php 16.66% <0.00%> (-33.34%) ⬇️
src/Http/src/Emitter/SapiEmitter.php 100.00% <100.00%> (ø)
src/Framework/Http/Diactoros/UriFactory.php 0.00% <0.00%> (-100.00%) ⬇️
...c/Framework/Debug/StateCollector/HttpCollector.php 80.00% <0.00%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 673f680...fc39bc1. Read the comment docs.

@roxblnfk roxblnfk requested a review from msmakouz March 23, 2022 09:29
@roxblnfk roxblnfk merged commit 3d26acc into master Mar 24, 2022
@roxblnfk roxblnfk deleted the feature/streaming-emmiting branch March 24, 2022 07:34
@butschster butschster added this to the 2.12 milestone Mar 31, 2022
roxblnfk pushed a commit that referenced this pull request Apr 11, 2022
@msmakouz
Merging v2.12 into v3.0-dev (#658)
20eeb6e 
* SapiEmitter now emits streaming (#602)
* Support for generators in controllers (#625)
* Marking deprecated code (#641)
* Update psr/log versions
* Using `self.version` instead of `*` (#653)
Co-authored-by: Aleksei Gagarin <roxblnfk@ya.ru>
Co-authored-by: Pavel Buchnev <butschster@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butschster butschster butschster approved these changes

@msmakouz msmakouz Awaiting requested review from msmakouz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.12
Development

Successfully merging this pull request may close these issues.
2 participants
@roxblnfk @butschster