Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating AuthHttp code with PHP 8.1 features #609

Merged
merged 5 commits into from
Mar 24, 2022
Merged

Updating AuthHttp code with PHP 8.1 features #609

merged 5 commits into from
Mar 24, 2022

Conversation

msmakouz
Copy link
Member

Q A
Bugfix?
Breaks BC?
New feature?
Issues #512

@msmakouz msmakouz added this to the 3.0 milestone Mar 24, 2022
@msmakouz msmakouz requested a review from roxblnfk March 24, 2022 14:04
@msmakouz msmakouz self-assigned this Mar 24, 2022
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #609 (8e09549) into 3.0 (21b6b3c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.0     #609      +/-   ##
============================================
- Coverage     83.49%   83.48%   -0.02%     
  Complexity     5873     5873              
============================================
  Files           667      667              
  Lines         14909    14893      -16     
============================================
- Hits          12449    12433      -16     
  Misses         2460     2460              
Impacted Files Coverage Δ
...hHttp/src/Middleware/Firewall/AbstractFirewall.php 100.00% <ø> (ø)
src/AuthHttp/src/Transport/CookieTransport.php 100.00% <ø> (ø)
src/AuthHttp/src/Middleware/AuthMiddleware.php 100.00% <100.00%> (ø)
...Http/src/Middleware/Firewall/ExceptionFirewall.php 100.00% <100.00%> (ø)
...Http/src/Middleware/Firewall/OverwriteFirewall.php 100.00% <100.00%> (ø)
src/AuthHttp/src/Transport/HeaderTransport.php 88.23% <100.00%> (-1.24%) ⬇️
src/AuthHttp/src/TransportRegistry.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b6b3c...8e09549. Read the comment docs.

@roxblnfk roxblnfk merged commit 06a5b93 into spiral:3.0 Mar 24, 2022
@msmakouz msmakouz deleted the maintenance/auth-http-php-81 branch April 4, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants