Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Console code with PHP 8.1 features #616

Merged
merged 9 commits into from
Mar 28, 2022
Merged

Updating Console code with PHP 8.1 features #616

merged 9 commits into from
Mar 28, 2022

Conversation

msmakouz
Copy link
Member

Q A
Bugfix?
Breaks BC? ✔️
New feature?
Issues #512

@msmakouz msmakouz added this to the 3.0 milestone Mar 24, 2022
@msmakouz msmakouz requested a review from roxblnfk March 24, 2022 17:32
@msmakouz msmakouz self-assigned this Mar 24, 2022
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #616 (9fdd12f) into 3.0 (df11dec) will decrease coverage by 0.01%.
The diff coverage is 85.91%.

@@             Coverage Diff              @@
##                3.0     #616      +/-   ##
============================================
- Coverage     83.50%   83.48%   -0.02%     
+ Complexity     5872     5867       -5     
============================================
  Files           667      667              
  Lines         14885    14851      -34     
============================================
- Hits          12430    12399      -31     
+ Misses         2455     2452       -3     
Impacted Files Coverage Δ
src/Console/src/Command/ConfigureCommand.php 100.00% <ø> (ø)
src/Console/src/Command/UpdateCommand.php 100.00% <ø> (ø)
src/Console/src/Sequence/CommandSequence.php 100.00% <ø> (ø)
src/Framework/Console/CommandLocator.php 83.33% <ø> (ø)
src/Console/src/InputProxy.php 61.29% <58.82%> (-2.35%) ⬇️
src/Console/src/Console.php 81.69% <82.35%> (-0.34%) ⬇️
src/Console/src/Bootloader/ConsoleBootloader.php 96.66% <100.00%> (-0.31%) ⬇️
src/Console/src/Command.php 100.00% <100.00%> (ø)
src/Console/src/Command/SequenceCommand.php 100.00% <100.00%> (ø)
src/Console/src/CommandOutput.php 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df11dec...9fdd12f. Read the comment docs.

@roxblnfk roxblnfk merged commit 8d239b3 into spiral:3.0 Mar 28, 2022
@msmakouz msmakouz deleted the maintenance/console-php-81 branch April 4, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants