Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating HTTP code with PHP 8.1 features #629

Merged
merged 7 commits into from
Mar 31, 2022
Merged

Updating HTTP code with PHP 8.1 features #629

merged 7 commits into from
Mar 31, 2022

Conversation

msmakouz
Copy link
Member

Q A
Bugfix?
Breaks BC? ✔️
New feature?
Issues #512

@msmakouz msmakouz added this to the 3.0 milestone Mar 27, 2022
@msmakouz msmakouz requested a review from roxblnfk March 27, 2022 13:58
@msmakouz msmakouz self-assigned this Mar 27, 2022
@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #629 (6d85520) into 3.0 (33244a6) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 6d85520 differs from pull request most recent head ceeb860. Consider uploading reports for the commit ceeb860 to get more accurate results

@@             Coverage Diff              @@
##                3.0     #629      +/-   ##
============================================
- Coverage     82.70%   82.66%   -0.04%     
+ Complexity     5858     5846      -12     
============================================
  Files           667      667              
  Lines         14761    14727      -34     
============================================
- Hits          12208    12174      -34     
  Misses         2553     2553              
Impacted Files Coverage Δ
src/Http/src/Config/HttpConfig.php 100.00% <ø> (ø)
.../Exception/ClientException/BadRequestException.php 100.00% <ø> (ø)
...c/Exception/ClientException/ForbiddenException.php 100.00% <ø> (ø)
...rc/Exception/ClientException/NotFoundException.php 100.00% <ø> (ø)
...Exception/ClientException/ServerErrorException.php 100.00% <ø> (ø)
...xception/ClientException/UnauthorizedException.php 100.00% <ø> (ø)
src/Http/src/Request/FilesBag.php 100.00% <ø> (ø)
src/Http/src/CallableHandler.php 100.00% <100.00%> (ø)
src/Http/src/Exception/ClientException.php 100.00% <100.00%> (ø)
src/Http/src/Header/AcceptHeader.php 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33244a6...ceeb860. Read the comment docs.

@roxblnfk roxblnfk merged commit 8088453 into spiral:3.0 Mar 31, 2022
@msmakouz msmakouz deleted the maintenance/http-php-81 branch April 4, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants