Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Queue code with PHP 8.1 features #635

Merged
merged 2 commits into from
Apr 2, 2022
Merged

Updating Queue code with PHP 8.1 features #635

merged 2 commits into from
Apr 2, 2022

Conversation

msmakouz
Copy link
Member

Q A
Bugfix?
Breaks BC?
New feature?
Issues #512

@msmakouz msmakouz added this to the 3.0 milestone Mar 27, 2022
@msmakouz msmakouz requested a review from roxblnfk March 27, 2022 21:06
@msmakouz msmakouz self-assigned this Mar 27, 2022
@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #635 (e00c0c2) into 3.0 (06a5b93) will decrease coverage by 1.00%.
The diff coverage is 51.85%.

@@             Coverage Diff              @@
##                3.0     #635      +/-   ##
============================================
- Coverage     83.48%   82.48%   -1.01%     
+ Complexity     5873     5764     -109     
============================================
  Files           667      667              
  Lines         14893    14418     -475     
============================================
- Hits          12433    11892     -541     
- Misses         2460     2526      +66     
Impacted Files Coverage Δ
src/Queue/src/Bootloader/QueueBootloader.php 0.00% <0.00%> (-85.72%) ⬇️
src/Queue/src/ContainerRegistry.php 0.00% <0.00%> (-18.75%) ⬇️
src/Queue/src/DefaultSerializer.php 0.00% <ø> (ø)
src/Queue/src/Driver/SyncDriver.php 90.90% <0.00%> (-1.40%) ⬇️
src/Queue/src/JobHandler.php 0.00% <0.00%> (ø)
src/Queue/src/Options.php 52.17% <0.00%> (ø)
src/Queue/src/Config/QueueConfig.php 95.55% <80.00%> (ø)
src/Queue/src/Core/QueueInjector.php 94.44% <100.00%> (-0.30%) ⬇️
src/Queue/src/Failed/LogFailedJobHandler.php 100.00% <100.00%> (ø)
src/Queue/src/Job/CallableJob.php 100.00% <100.00%> (ø)
... and 330 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06a5b93...e00c0c2. Read the comment docs.

@roxblnfk roxblnfk merged commit 040234a into spiral:3.0 Apr 2, 2022
@msmakouz msmakouz deleted the maintenance/queue-php-81 branch April 4, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants