Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Reactor code with PHP 8.1 features #638

Merged
merged 4 commits into from
Apr 2, 2022
Merged

Updating Reactor code with PHP 8.1 features #638

merged 4 commits into from
Apr 2, 2022

Conversation

msmakouz
Copy link
Member

Q A
Bugfix?
Breaks BC? ✔️
New feature?
Issues #512

@msmakouz msmakouz added this to the 3.0 milestone Mar 28, 2022
@msmakouz msmakouz requested a review from roxblnfk March 28, 2022 11:19
@msmakouz msmakouz self-assigned this Mar 28, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #638 (541b0b8) into 3.0 (0c85859) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.0     #638      +/-   ##
============================================
- Coverage     82.45%   82.45%   -0.01%     
+ Complexity     5763     5762       -1     
============================================
  Files           667      667              
  Lines         14401    14394       -7     
============================================
- Hits          11875    11868       -7     
  Misses         2526     2526              
Impacted Files Coverage Δ
src/Reactor/src/Aggregator/Constants.php 100.00% <ø> (ø)
src/Reactor/src/Aggregator/Methods.php 100.00% <ø> (ø)
src/Reactor/src/Aggregator/Properties.php 100.00% <ø> (ø)
src/Reactor/src/Traits/NamedTrait.php 100.00% <ø> (ø)
src/Reactor/src/Traits/SerializerTrait.php 100.00% <ø> (ø)
src/Reactor/src/AbstractDeclaration.php 100.00% <100.00%> (ø)
src/Reactor/src/Aggregator.php 100.00% <100.00%> (ø)
src/Reactor/src/Aggregator/Parameters.php 100.00% <100.00%> (ø)
src/Reactor/src/ClassDeclaration.php 100.00% <100.00%> (ø)
src/Reactor/src/FileDeclaration.php 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c85859...541b0b8. Read the comment docs.

@roxblnfk roxblnfk merged commit c91aa21 into spiral:3.0 Apr 2, 2022
@msmakouz msmakouz deleted the maintenance/reactor-php-81 branch April 4, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants