Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Scaffolder code with PHP 8.1 features #640

Merged
merged 4 commits into from
Apr 2, 2022
Merged

Updating Scaffolder code with PHP 8.1 features #640

merged 4 commits into from
Apr 2, 2022

Conversation

msmakouz
Copy link
Member

Q A
Bugfix?
Breaks BC?
New feature?
Issues #512

@msmakouz msmakouz added this to the 3.0 milestone Mar 28, 2022
@msmakouz msmakouz requested a review from roxblnfk March 28, 2022 18:21
@msmakouz msmakouz self-assigned this Mar 28, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #640 (5e0d20b) into 3.0 (ae91fcb) will decrease coverage by 0.01%.
The diff coverage is 90.52%.

@@             Coverage Diff              @@
##                3.0     #640      +/-   ##
============================================
- Coverage     82.41%   82.40%   -0.02%     
  Complexity     5750     5750              
============================================
  Files           667      667              
  Lines         14362    14352      -10     
============================================
- Hits          11837    11827      -10     
  Misses         2525     2525              
Impacted Files Coverage Δ
...affolder/src/Declaration/BootloaderDeclaration.php 100.00% <ø> (ø)
.../Scaffolder/src/Declaration/CommandDeclaration.php 100.00% <ø> (ø)
...er/src/Declaration/ConfigDeclaration/TypeHints.php 100.00% <ø> (ø)
...affolder/src/Declaration/JobHandlerDeclaration.php 100.00% <ø> (ø)
...affolder/src/Declaration/MiddlewareDeclaration.php 100.00% <ø> (ø)
...Scaffolder/src/Bootloader/ScaffolderBootloader.php 80.95% <50.00%> (-1.66%) ⬇️
src/Scaffolder/src/helpers.php 68.75% <50.00%> (-3.48%) ⬇️
src/Scaffolder/src/Config/ScaffolderConfig.php 93.44% <86.66%> (ø)
...c/Scaffolder/src/Declaration/ConfigDeclaration.php 98.98% <95.00%> (-0.08%) ⬇️
src/Scaffolder/src/Command/AbstractCommand.php 90.00% <100.00%> (-0.70%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae91fcb...5e0d20b. Read the comment docs.

@roxblnfk roxblnfk merged commit 32b1a13 into spiral:3.0 Apr 2, 2022
@msmakouz msmakouz deleted the maintenance/scaffolder-php-81 branch April 4, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants