Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating SendIt code with PHP 8.1 features #643

Merged
merged 3 commits into from
Apr 2, 2022
Merged

Updating SendIt code with PHP 8.1 features #643

merged 3 commits into from
Apr 2, 2022

Conversation

msmakouz
Copy link
Member

Q A
Bugfix?
Breaks BC? ✔️
New feature?
Issues #512

@msmakouz msmakouz added this to the 3.0 milestone Mar 29, 2022
@msmakouz msmakouz requested a review from roxblnfk March 29, 2022 10:11
@msmakouz msmakouz self-assigned this Mar 29, 2022
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #643 (11440f5) into 3.0 (7839ad5) will increase coverage by 0.00%.
The diff coverage is 45.45%.

@@            Coverage Diff            @@
##                3.0     #643   +/-   ##
=========================================
  Coverage     82.39%   82.39%           
  Complexity     5746     5746           
=========================================
  Files           667      667           
  Lines         14339    14329   -10     
=========================================
- Hits          11814    11807    -7     
+ Misses         2525     2522    -3     
Impacted Files Coverage Δ
src/SendIt/src/Bootloader/BuilderBootloader.php 0.00% <ø> (ø)
src/SendIt/src/Bootloader/MailerBootloader.php 0.00% <0.00%> (ø)
src/SendIt/src/MessageSerializer.php 90.47% <0.00%> (ø)
src/SendIt/src/Renderer/ViewRenderer.php 0.00% <0.00%> (ø)
src/SendIt/src/Config/MailerConfig.php 100.00% <100.00%> (ø)
src/SendIt/src/MailJob.php 96.77% <100.00%> (-0.45%) ⬇️
src/SendIt/src/MailQueue.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7839ad5...11440f5. Read the comment docs.

@roxblnfk roxblnfk merged commit 1023602 into spiral:3.0 Apr 2, 2022
@msmakouz msmakouz deleted the maintenance/sendit-php-81 branch April 4, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants