Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Views code with PHP 8.1 features #649

Merged
merged 4 commits into from
Apr 3, 2022
Merged

Updating Views code with PHP 8.1 features #649

merged 4 commits into from
Apr 3, 2022

Conversation

msmakouz
Copy link
Member

Q A
Bugfix?
Breaks BC? ✔️
New feature?
Issues #512

@msmakouz msmakouz added this to the 3.0 milestone Mar 31, 2022
@msmakouz msmakouz requested a review from roxblnfk March 31, 2022 21:12
@msmakouz msmakouz self-assigned this Mar 31, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #649 (103d796) into 3.0 (cded44d) will decrease coverage by 0.02%.
The diff coverage is 95.31%.

@@             Coverage Diff              @@
##                3.0     #649      +/-   ##
============================================
- Coverage     82.31%   82.28%   -0.03%     
+ Complexity     5716     5711       -5     
============================================
  Files           667      667              
  Lines         14191    14167      -24     
============================================
- Hits          11682    11658      -24     
  Misses         2509     2509              
Impacted Files Coverage Δ
src/Views/src/Engine/AbstractEngine.php 100.00% <ø> (ø)
src/Views/src/Exception/CompileException.php 0.00% <0.00%> (ø)
src/Views/src/Traits/ProcessorTrait.php 100.00% <ø> (ø)
src/Views/src/Config/ViewsConfig.php 100.00% <100.00%> (ø)
src/Views/src/Context/ValueDependency.php 100.00% <100.00%> (ø)
src/Views/src/ContextGenerator.php 100.00% <100.00%> (ø)
src/Views/src/Engine/Native/NativeEngine.php 100.00% <100.00%> (ø)
src/Views/src/Engine/Native/NativeView.php 100.00% <100.00%> (ø)
src/Views/src/Exception/RenderException.php 50.00% <100.00%> (ø)
src/Views/src/Loader/PathParser.php 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cded44d...103d796. Read the comment docs.

@roxblnfk roxblnfk merged commit eab021e into spiral:3.0 Apr 3, 2022
@msmakouz msmakouz deleted the maintenance/views-php-81 branch April 4, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants