Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Bootloaders place #652

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Changing Bootloaders place #652

merged 2 commits into from
Apr 7, 2022

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Apr 4, 2022

Q A
Bugfix?
Breaks BC? ✔️
New feature?
Issues #531

@msmakouz msmakouz added this to the 3.0 milestone Apr 4, 2022
@msmakouz msmakouz requested a review from butschster April 4, 2022 10:33
@msmakouz msmakouz self-assigned this Apr 4, 2022
@msmakouz msmakouz linked an issue Apr 4, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #652 (188fdb2) into 3.0 (eab021e) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                3.0     #652   +/-   ##
=========================================
  Coverage     82.28%   82.28%           
  Complexity     5711     5711           
=========================================
  Files           667      667           
  Lines         14167    14167           
=========================================
  Hits          11658    11658           
  Misses         2509     2509           
Impacted Files Coverage Δ
...outes/src/Bootloader/AnnotatedRoutesBootloader.php 92.00% <ø> (ø)
...Attributes/src/Bootloader/AttributesBootloader.php 63.63% <ø> (ø)
...dge/Stempler/src/Bootloader/StemplerBootloader.php 48.00% <ø> (ø)
...ribution/src/Bootloader/DistributionBootloader.php 0.00% <ø> (ø)
src/Distribution/src/Config/DistributionConfig.php 0.00% <ø> (ø)
...ramework/Bootloader/Security/FiltersBootloader.php 100.00% <ø> (ø)
...ork/Bootloader/Views/TranslatedCacheBootloader.php 100.00% <ø> (ø)
...c/Prototype/src/Bootloader/PrototypeBootloader.php 87.50% <ø> (ø)
src/SendIt/src/Bootloader/BuilderBootloader.php 0.00% <ø> (ø)
src/Storage/src/Bootloader/StorageBootloader.php 72.72% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab021e...188fdb2. Read the comment docs.

@butschster butschster merged commit 97f796e into spiral:3.0 Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Sort out bootloaders placement
2 participants