Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Queueable attribute #662

Merged
merged 7 commits into from
Apr 28, 2022
Merged

Adding Queueable attribute #662

merged 7 commits into from
Apr 28, 2022

Conversation

msmakouz
Copy link
Member

Q A
Bugfix?
Breaks BC?
New feature? ✔️
Issues #542

Interface already added:
https://github.com/spiral/framework/blob/master/src/Queue/src/QueueableInterface.php

@msmakouz msmakouz added this to the 2.13 milestone Apr 18, 2022
@msmakouz msmakouz requested a review from butschster April 18, 2022 09:39
@msmakouz msmakouz self-assigned this Apr 18, 2022
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #662 (56683e3) into master (3c9217f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #662      +/-   ##
============================================
+ Coverage     79.88%   79.90%   +0.02%     
- Complexity     6713     6721       +8     
============================================
  Files           755      757       +2     
  Lines         17005    17022      +17     
============================================
+ Hits          13585    13602      +17     
  Misses         3420     3420              
Impacted Files Coverage Δ
src/Queue/src/Attribute/Queueable.php 100.00% <100.00%> (ø)
src/Queue/src/QueueableDetector.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c9217f...56683e3. Read the comment docs.

@msmakouz msmakouz marked this pull request as draft April 20, 2022 07:58
@msmakouz msmakouz marked this pull request as ready for review April 27, 2022 05:14
@butschster butschster merged commit 59c7c40 into spiral:master Apr 28, 2022
@msmakouz msmakouz deleted the feature/queueable branch April 29, 2022 10:03
@butschster butschster linked an issue May 4, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add ShouldBeQueuedInterface
2 participants