Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving SAPI to standalone package #666

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Moving SAPI to standalone package #666

merged 3 commits into from
Apr 27, 2022

Conversation

msmakouz
Copy link
Member

Q A
Bugfix?
Breaks BC? ✔️
New feature?

@msmakouz msmakouz added this to the 3.0 milestone Apr 21, 2022
@msmakouz msmakouz requested a review from roxblnfk April 21, 2022 06:58
@msmakouz msmakouz self-assigned this Apr 21, 2022
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #666 (c09eb03) into 3.0 (9976ff3) will increase coverage by 0.07%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##                3.0     #666      +/-   ##
============================================
+ Coverage     81.95%   82.03%   +0.07%     
+ Complexity     5423     5399      -24     
============================================
  Files           609      607       -2     
  Lines         13624    13556      -68     
============================================
- Hits          11166    11120      -46     
+ Misses         2458     2436      -22     
Impacted Files Coverage Δ
...work/Debug/StateCollector/EnvironmentCollector.php 0.00% <0.00%> (ø)
src/Framework/Bootloader/Http/HttpBootloader.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9976ff3...c09eb03. Read the comment docs.

Copy link
Member

@roxblnfk roxblnfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It need to remove this line from changelog:

- [spiral/http] Added return type `bool` to the method `emit` in `Spiral\Http\EmitterInterface` interface.

@msmakouz msmakouz requested a review from roxblnfk April 27, 2022 05:50
@roxblnfk roxblnfk merged commit 7c87900 into spiral:3.0 Apr 27, 2022
@msmakouz msmakouz deleted the maintenance/sapi branch April 29, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants