Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Broadcasting code with PHP 8.1 features #680

Merged
merged 6 commits into from
May 4, 2022
Merged

Updating Broadcasting code with PHP 8.1 features #680

merged 6 commits into from
May 4, 2022

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented May 3, 2022

Q A
Bugfix?
Breaks BC?
New feature?
Issues #678

@msmakouz msmakouz added this to the 3.0 milestone May 3, 2022
@msmakouz msmakouz requested a review from roxblnfk May 3, 2022 09:41
@msmakouz msmakouz self-assigned this May 3, 2022
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #680 (001c163) into 3.0 (1ca0ee8) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.0     #680      +/-   ##
============================================
+ Coverage     82.06%   82.13%   +0.07%     
+ Complexity     5492     5369     -123     
============================================
  Files           623      605      -18     
  Lines         13755    13330     -425     
============================================
- Hits          11288    10949     -339     
+ Misses         2467     2381      -86     
Impacted Files Coverage Δ
src/Broadcasting/src/AuthorizationStatus.php 100.00% <ø> (ø)
src/Exceptions/src/ExceptionHandler.php 72.54% <ø> (ø)
src/Http/src/Middleware/ErrorHandlerMiddleware.php 50.00% <ø> (ø)
...dcasting/src/Bootloader/BroadcastingBootloader.php 50.00% <100.00%> (-2.95%) ⬇️
...oadcasting/src/Bootloader/WebsocketsBootloader.php 57.14% <100.00%> (+57.14%) ⬆️
src/Broadcasting/src/BroadcastManager.php 100.00% <100.00%> (ø)
src/Broadcasting/src/Config/BroadcastConfig.php 88.46% <100.00%> (ø)
src/Broadcasting/src/Driver/AbstractBroadcast.php 100.00% <100.00%> (+10.00%) ⬆️
src/Broadcasting/src/Driver/LogBroadcast.php 100.00% <100.00%> (ø)
src/Broadcasting/src/Driver/NullBroadcast.php 100.00% <100.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ca0ee8...001c163. Read the comment docs.

@msmakouz msmakouz linked an issue May 3, 2022 that may be closed by this pull request
@msmakouz msmakouz requested review from butschster and roxblnfk May 4, 2022 08:01
@butschster butschster merged commit 1b4b65e into spiral:3.0 May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update Broadcasting component to PHP 8.1
3 participants