Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming starting/started methods #686

Merged
merged 1 commit into from
May 13, 2022
Merged

Renaming starting/started methods #686

merged 1 commit into from
May 13, 2022

Conversation

msmakouz
Copy link
Member

Q A
Bugfix?
Breaks BC? ✔️
New feature?

@msmakouz msmakouz added this to the 3.0 milestone May 13, 2022
@msmakouz msmakouz requested a review from butschster May 13, 2022 05:21
@msmakouz msmakouz self-assigned this May 13, 2022
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #686 (56b314f) into 3.0 (1b4b65e) will not change coverage.
The diff coverage is 90.90%.

@@            Coverage Diff            @@
##                3.0     #686   +/-   ##
=========================================
  Coverage     82.16%   82.16%           
  Complexity     5369     5369           
=========================================
  Files           604      604           
  Lines         13326    13326           
=========================================
  Hits          10949    10949           
  Misses         2377     2377           
Impacted Files Coverage Δ
src/Queue/src/Bootloader/QueueBootloader.php 0.00% <0.00%> (ø)
src/Boot/src/AbstractKernel.php 95.65% <100.00%> (ø)
src/Boot/src/BootloadManager/BootloadManager.php 100.00% <100.00%> (ø)
src/Console/src/Bootloader/ConsoleBootloader.php 96.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b4b65e...56b314f. Read the comment docs.

@butschster butschster merged commit 7d1fbbd into spiral:3.0 May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants