Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make container replaceable in the App #689

Merged
merged 1 commit into from
May 16, 2022

Conversation

roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented May 16, 2022

<?php

$container = new Container();
$container->bind('foo', new stdClass());

$app = \App\App::create([
    'root'    => __DIR__ . '/../..',
], container: $container);

@roxblnfk roxblnfk added this to the 3.0 milestone May 16, 2022
@roxblnfk roxblnfk requested a review from butschster May 16, 2022 07:51
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #689 (a032037) into 3.0 (dc1346e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                3.0     #689   +/-   ##
=========================================
  Coverage     82.36%   82.37%           
  Complexity     5454     5454           
=========================================
  Files           621      621           
  Lines         13539    13538    -1     
=========================================
  Hits          11152    11152           
+ Misses         2387     2386    -1     
Impacted Files Coverage Δ
src/Boot/src/AbstractKernel.php 95.58% <100.00%> (-0.07%) ⬇️
src/Framework/Framework/Kernel.php 100.00% <0.00%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc1346e...a032037. Read the comment docs.

@butschster butschster merged commit b9522d0 into 3.0 May 16, 2022
@butschster butschster deleted the feature/replaceable-app-container branch May 16, 2022 15:03
@butschster butschster self-assigned this Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants