feat: Zero-copy BufMessageReader #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
gatesn
commented
Dec 30, 2024
lwwmanning
approved these changes
Dec 30, 2024
| @@ -300,6 +310,28 @@ impl From<Bytes> for ByteBuffer { | |||
| } | |||
| } | |||
|
|
|||
| impl Buf for ByteBuffer { | |||
| fn remaining(&self) -> usize { | |||
There was a problem hiding this comment.
the semantics of this trait were a bit hard to divine without checking out the code and jumping to source
lwwmanning
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suppose this should really be called "less copy"
We still copy more than we need to, but that requires a change to
VortexReadAtto take abytes::BufMutby ownership, allowing us to pass in pre-aligned buffers.