Upgrade to arrow 54 and datafusion 45 #2271
Open
+283
−256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
commented
Feb 7, 2025
|
|
||
| Self::try_from_parts( | ||
| DType::Bool(validity.nullability()), | ||
| buffer_len, | ||
| RkyvMetadata(BoolMetadata { | ||
| validity: validity.to_metadata(buffer_len)?, | ||
| first_byte_bit_offset, | ||
| first_byte_bit_offset: 0, |
There was a problem hiding this comment.
Do we want to break it here?
AdamGS
commented
Feb 7, 2025
| @@ -83,8 +83,7 @@ impl BoolArray { | |||
| /// otherwise a copy is created. | |||
There was a problem hiding this comment.
There are a bunch of changes in this file that are due to a change in arrow. We can try and make sure we always make shallow copies, I'll try to add that later today/next week.
AdamGS
commented
Feb 7, 2025
| let inner = buffer | ||
| .into_inner() | ||
| .bit_slice(buffer_byte_offset, buffer_len); | ||
| let inner = buffer.into_inner().bit_slice(buffer_offset, buffer_len); |
There was a problem hiding this comment.
arrow changed the behavior of bit_slice in cases where the slicing is aligned, see my other comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including the pyo3 version bump (#2270 and #2042)