Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: slim down vortex-array metadata #951

Merged
merged 4 commits into from
Oct 1, 2024
Merged

feat: slim down vortex-array metadata #951

merged 4 commits into from
Oct 1, 2024

Commits on Oct 1, 2024

  1. feat: slim down vortex-array metadata 

    1. Never store an array's own length in metadata.
   - In memory, it is stored in the `TypedArray`.
   - On disk/network, the top-level array length is in the flatbuffer `Batch`.
   - On disk/network, non-top-level array lengths are derivable from their parent's length and metadata.
2. DTypes can often be PType.
3. Scalar can often be ScalarValue (because the dtype is derivable by the Array's dtype).
    @danking
    danking committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6799c89 View commit details
    Browse the repository at this point in the history

  2. address comments

    @danking
    danking committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    53bf57c View commit details
    Browse the repository at this point in the history

  3. address simple comments

    @danking
    danking committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    b10c68e View commit details
    Browse the repository at this point in the history

  4. do not store indices_ptype in SparseMetadata

    @danking
    danking committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ba1e0b5 View commit details
    Browse the repository at this point in the history