Add crate-wide config to all crates; customize clippy settings

Enable checking of excessive bool parameters in all crates, and limit to 1.
Limit the number of arguments to 5.

Signed-off-by: J Robert Ray <jrray@jrray.org>

.clippy.toml

@@ -0,0 +1,5 @@
+# default is 3
+max-fn-params-bools = 1
+
+# default is 7
+too-many-arguments-threshold = 5

crates/parsedbuf/src/lib.rs

@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub use paste;
 

crates/spfs-cli/cmd-clean/src/cmd_clean.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 use chrono::prelude::*;
 use clap::Parser;
 use colored::*;

crates/spfs-cli/cmd-enter/src/cmd_enter.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 use std::ffi::OsString;
 
 use clap::Parser;

crates/spfs-cli/cmd-join/src/cmd_join.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 use std::ffi::OsString;
 
 use clap::Parser;

crates/spfs-cli/cmd-monitor/src/cmd_monitor.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 use std::time::Duration;
 
 use clap::Parser;

crates/spfs-cli/common/src/lib.rs

@@ -1,3 +1,6 @@
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 //! Common macros and argument structures for the spfs command line
 
 mod args;

crates/spfs-cli/main/src/bin.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 use clap::{Parser, Subcommand};
 use spfs::Error;
 

crates/spfs-cli/main/src/cmd_write.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 use std::path::PathBuf;
 
 use clap::Args;

crates/spfs-encoding/src/lib.rs

@@ -12,6 +12,7 @@
 
 #![deny(missing_docs)]
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 mod binary;
 mod error;

crates/spfs/src/bootstrap.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 use std::ffi::{OsStr, OsString};
 use std::path::{Path, PathBuf};
 

crates/spfs/src/config.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 use std::path::PathBuf;
 use std::sync::{Arc, RwLock};
 

crates/spfs/src/error.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 use std::io;
 use std::str::Utf8Error;
 

crates/spfs/src/lib.rs

@@ -2,9 +2,10 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
-//! Filesystem isolation, capture and distribution.
-
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
+//! Filesystem isolation, capture and distribution.
 
 pub const VERSION: &str = env!("CARGO_PKG_VERSION");
 

crates/spfs/src/proto/conversions.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 use std::convert::{TryFrom, TryInto};
 use std::ops::Not;
 

crates/spfs/src/proto/mod.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 //! Protocol Buffer message formats and conversions.
 
 mod conversions;

crates/spfs/src/resolve_test.rs

@@ -1,8 +1,9 @@
-use std::sync::Arc;
-
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
+use std::sync::Arc;
+
 use rstest::rstest;
 
 use super::resolve_stack_to_layers;

crates/spfs/src/server/database.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 use std::convert::TryInto;
 use std::pin::Pin;
 use std::sync::Arc;

crates/spfs/src/server/mod.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 //! Remote rpc server implementation of the spfs repository
 mod database;
 mod payload;

crates/spfs/src/server/tag.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 use std::convert::TryInto;
 use std::sync::Arc;
 

crates/spfs/src/storage/config.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 use async_trait::async_trait;
 
 use crate::Result;

crates/spfs/src/storage/database_test.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 use rstest::rstest;
 
 use crate::fixtures::*;

crates/spfs/src/storage/payload_test.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 use futures::TryStreamExt;
 use rstest::rstest;
 use tokio::io::AsyncReadExt;

crates/spfs/src/storage/repository.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 use std::collections::HashSet;
 use std::pin::Pin;
 

crates/spfs/src/storage/rpc/mod.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 //! Storage implementation which is a client of the built-in spfs server
 
 mod database;

crates/spfs/src/storage/rpc/payload.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 use std::convert::TryInto;
 use std::pin::Pin;
 

crates/spfs/src/storage/tag_test.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 use std::os::unix::fs::MetadataExt;
 
 use chrono::prelude::*;

crates/spk-build/src/build/mod.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 mod binary;
 mod sources;
 

crates/spk-build/src/build/sources_test.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 use rstest::rstest;
 use spk_schema::foundation::fixtures::*;
 use spk_schema::ident::build_ident;

crates/spk-build/src/lib.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod build;
 mod error;
 

crates/spk-cli/cmd-build/src/lib.rs

@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_build;

crates/spk-cli/cmd-convert/src/lib.rs

@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_convert;

crates/spk-cli/cmd-env/src/cmd_env.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 use std::ffi::OsString;
 
 use anyhow::{Context, Result};

crates/spk-cli/cmd-env/src/lib.rs

@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_env;

crates/spk-cli/cmd-explain/src/lib.rs

@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_explain;

crates/spk-cli/cmd-install/src/lib.rs

@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_install;

crates/spk-cli/cmd-make-binary/src/lib.rs

@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_make_binary;

crates/spk-cli/cmd-make-source/src/lib.rs

@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_make_source;

crates/spk-cli/cmd-render/src/cmd_render.rs

@@ -1,6 +1,10 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 use std::path::PathBuf;
 
 use anyhow::{bail, Context, Result};

crates/spk-cli/cmd-render/src/lib.rs

@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_render;

crates/spk-cli/cmd-repo/src/lib.rs

@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_repo;

crates/spk-cli/cmd-test/src/cmd_test.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 use std::str::FromStr;
 use std::sync::Arc;
 

crates/spk-cli/cmd-test/src/lib.rs

@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_test;
 

crates/spk-cli/common/src/cli.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 //! Main entry points and utilities for command line interface and interaction.
 
 use anyhow::Result;

crates/spk-cli/common/src/lib.rs

@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 mod cli;
 mod env;

crates/spk-cli/group1/src/cmd_deprecate.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 use std::io::Write;
 use std::sync::Arc;
 

crates/spk-cli/group1/src/lib.rs

@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_bake;
 pub mod cmd_deprecate;

crates/spk-cli/group2/src/cmd_new.rs

@@ -1,6 +1,7 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
 use anyhow::Result;
 use clap::Args;
 use colored::Colorize;