Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symfony/yaml v7 #227

Merged
merged 1 commit into from
May 14, 2024

Conversation

jbreton
Copy link
Contributor

@jbreton jbreton commented Apr 15, 2024

https://github.com/symfony/yaml/blob/7.0/CHANGELOG.md#70

Breaking change limited to how php constants can be used.

PHP SDK

What did you accomplish?

How do we test the changes introduced in this PR?

Extra Notes

https://github.com/symfony/yaml/blob/7.0/CHANGELOG.md#70

Breaking change limited to how php constants can be used.
@jbreton jbreton requested a review from a team as a code owner April 15, 2024 19:15
Copy link
Contributor

@sanzmauro sanzmauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanzmauro sanzmauro changed the base branch from master to sdks-8242-semver-imp May 14, 2024 14:20
@sanzmauro sanzmauro merged commit 6600ab7 into splitio:sdks-8242-semver-imp May 14, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants