Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #max_experiments_reached? when using allow_multiple_experiments=control #613

Merged

Conversation

andrehjr
Copy link
Member

@andrehjr andrehjr commented May 2, 2020

When using allow_multiple_experiments=control Split only allows one
experiment with an alternative other than 'control'.

Split::User#max_experiments_reached? checks for that looping through all
experiments. As Split::User#active_experiments drop the experiment
version we also need to do that here to be able to check properly.

Fixes #612

…ontrol

When using allow_multiple_experiments=control Split only allows one
experiment with an alternative other than 'control'.

Split::User#max_experiments_reached? checks for that looping through all
experiments. As Split::User#active_experiments drops the experiment
version we also need to do that here to be able to check properly.

Fixes #612
@andrehjr andrehjr force-pushed the fix-allow_multiple_experiments-control-with-versions branch from 05243ed to 0d2178e Compare May 4, 2020 01:26
@andrehjr andrehjr merged commit f48c196 into master May 4, 2020
@andrehjr andrehjr deleted the fix-allow_multiple_experiments-control-with-versions branch May 4, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experiment versions cause confusion with allow_multiple_experiments='control'
1 participant