Fix #max_experiments_reached? when using allow_multiple_experiments=control #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontrol When using allow_multiple_experiments=control Split only allows one experiment with an alternative other than 'control'. Split::User#max_experiments_reached? checks for that looping through all experiments. As Split::User#active_experiments drops the experiment version we also need to do that here to be able to check properly. Fixes #612
andrehjr
force-pushed
the
fix-allow_multiple_experiments-control-with-versions
branch
from
05243ed
to
0d2178e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using allow_multiple_experiments=control Split only allows one
experiment with an alternative other than 'control'.
Split::User#max_experiments_reached? checks for that looping through all
experiments. As Split::User#active_experiments drop the experiment
version we also need to do that here to be able to check properly.
Fixes #612