Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make specs compatible with newer rack #722

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Conversation

andrehjr
Copy link
Member

@andrehjr andrehjr commented Mar 3, 2024

The response from context.response.headers["Set-Cookie"]) changed a bit, so I'm updating the specs to reflect that between older/newer versions of rack.

There's also a new deprecation that needs to be addressed. Will do it on a later PR.

warning: Rack::Response#header is deprecated and will be removed in Rack 3.1

@andrehjr andrehjr merged commit e8120d1 into main Mar 3, 2024
11 checks passed
@andrehjr andrehjr deleted the update-specs-newer-rack branch March 3, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant