-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color setting for setPrefix #276
Conversation
I'm happy to include this feature, but I don't think I want to include parsing color constants as part of the library. The second version of the method seems good to me and I'd probably include something like this in the docstring:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One quick fix, then this should be good. Thanks for the help!
@@ -63,7 +63,7 @@ protected boolean keepObject(Person person, String mask) { | |||
|
|||
|
|||
if (savedInstanceState == null) { | |||
completionView.setPrefix("To: "); | |||
completionView.setPrefix("To: ", "blue"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be:
completionView.setPrefix("To: ", Color.parseColor("blue"));
@@ -3,6 +3,7 @@ | |||
import android.annotation.TargetApi; | |||
import android.content.Context; | |||
import android.content.res.ColorStateList; | |||
import android.graphics.Color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't need this import any more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Thanks for making this awesome library! I will be happy to help out with other parts too. Any idea when you will be planning out the next version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure - it depends on how quickly I get feedback on #272 and priorities on this at my job.
No description provided.