#97 - Fixup match array as string #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @guiferrpereira. Thanks for this PR. Is it possible for you to add a new context and test to this file https://github.com/mcmire/super_diff/blob/master/spec/integration/rspec/match_array_matcher_spec.rb which makes sure that this isn't an issue going forward? |
guiferrpereira
force-pushed
the
97_fix_match_array_string
branch
from
8175d26
to
9726c3e
Compare
|
@mcmire specs added |
|
Okay! Thanks so much! |
|
@mcmire can you create the 0.5.3 release please? thanks |
|
@guiferrpereira Yes, thanks for the reminder. 0.5.3 is now available with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects issue #97