Fix float issue with object space dump #146
Conversation
.tool-versions
Outdated
| @@ -1 +1 @@ | |||
| ruby 2.5.9 | |||
| ruby 2.7.1 | |||
There was a problem hiding this comment.
Thanks for the change! Mind putting this in another PR? This seems like something someone may want to track down later and I don't want it to get lost in this one.
There was a problem hiding this comment.
Actually, take that back — since we still support Ruby 2.5 as the minimum tested version, we probably want to leave this alone :)
There was a problem hiding this comment.
I reverted it in 2450859
There was a problem hiding this comment.
I will fix this error in the test suite
NoMethodError:
undefined method `try' for #<Hash>
Did you mean? pry
There was a problem hiding this comment.
I think 55d9dc2 should fix that issue
There was a problem hiding this comment.
The remainder that are failing are probably due to an issue with ruby version + minitest version issues, I pushed up #148 to try and fix the issue
This reverts commit a663893.
|
I merged |
|
Done and merged! |
A fix for #144 and align
.tool-versionwith.ruby-version