Update dev Ruby; drop old Rubies and Rails #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
drop-old-rubies-and-rails
branch
7 times, most recently
from
1004f23
to
a0a8fbb
Compare
We support versions of Ruby and Rails which are or are about to be EOL: - Ruby 2.5 and 2.6 are already EOL, and Ruby 2.7 will be EOL starting April 1st, 2023 ([1]). - Rails 5.0, 5.1, and 5.2 are already EOL ([2]). To address this, I've removed support for these from the Appraisals file as well as the CI matrix. I've also simplified the Appraisals file and CI matrix, as we were excluding combinations of Rails and RSpec versions that didn't need to be excluded. I've also updated Appraisal to the latest commit within the repo. For some reason, if you remove `gemfiles` entirely and then re-run `appraisal install`, Appraisal will complain that a lockfile doesn't exist. This seems to be fixed in more recent commits. (I tried to fix this in another commit, but then you need to be able to update _all_ of the appraisal gemfiles. But to do this, you need to be able to switch to old versions of Rubies, but I can't do this because those won't install on new versions of macOS. This commit removes the old Rubies, so that's unnecessary.) Finally, I've updated the GitHub Actions workflow to run the lint and audit jobs first, then run the test job if those succeed. [1]: https://endoflife.date/ruby [2]: https://endoflife.date/rails
mcmire
force-pushed
the
drop-old-rubies-and-rails
branch
from
a0a8fbb
to
c6e9f14
Compare
mcmire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support versions of Ruby and Rails which are or are about to be EOL:
To address this, I've removed support for these from the Appraisals file as well as the CI matrix. I've also simplified the Appraisals file and CI matrix, as we were excluding combinations of Rails and RSpec versions that didn't need to be excluded.
Finally, I've updated Appraisal to the latest commit within the repo. For some reason, if you remove
gemfilesentirely and then re-runappraisal install, Appraisal will complain that a lockfile doesn't exist. This seems to be fixed in more recent commits. (I tried to fix this in another commit, but then you need to be able to update all of the appraisal gemfiles. But to do this, you need to be able to switch to old versions of Rubies, but I can't do this because those won't install on new versions of macOS. This commit removes the old Rubies, so that's unnecessary.)